Add ha-subppage toolbar css styles#4409
Merged
Merged
Conversation
Contributor
Contributor
Author
|
I'm not sure this is the right approach, but I'm new to the hass codebase and mostly just opened the PR to create a discussion around the best solution. You'll see the behavior I'm trying to address by using the 'synthwave' theme from the HACS default repos. |
bramkragten
reviewed
Jan 2, 2020
dcramer
force-pushed
the
fix/toolbar-background
branch
from
88fd291 to
3349e72
Compare
bramkragten
approved these changes
Jan 2, 2020
dcramer
added a commit
to dcramer/synthwave-hass
that referenced
this pull request
Jan 2, 2020
This binds the primary-color to be used primarily for text, and overrides app-header's background color (which defaults to primary-color). It resolves a few situations such as links in the notifications pullout, and with the upstream change, the toolbar on other pages. See also home-assistant/frontend#4409
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses an issue with styling the toolbar in the same way that the app-header had been previously addressed.
This specific case can be reproduced by doing the following: